feat: createBaseRouter in TS #1022
Merged
+85
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golota60
commented
Dec 22, 2022
src/Redirect.tsx
Outdated
Comment on lines
42
to
45
| class RedirectType extends React.Component<RedirectOptions> { | ||
| // @ts-ignore | ||
| constructor(config: RedirectOptions); | ||
| } |
There was a problem hiding this comment.
I don't know whether there's a better way to do this. The problem is i need consumer(the user of the library) to think this component extends React.Component but I don't want to actually extend
There was a problem hiding this comment.
I think this is ok but maybe do:
declare class RedirectType extends React.Component<RedirectOptions> {
constructor(config: RedirectOptions);
}with the declare which should make it just a type?
golota60
commented
Dec 22, 2022
Comment on lines
+8
to
+12
| path?: string; | ||
|
|
||
| to: string | ((match: Match) => LocationDescriptor); | ||
|
|
||
| status?: number; |
There was a problem hiding this comment.
I decided to just declare fields on classes. Technically those are functional changes, but practically they should not change anything. I'm pretty sure the only difference is that this has those initialized as undefined when creating the instance, which should not change anything
|
Nice work, I was dreading these weird objects :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was the most painful to do :P